Skip to content

Conversation

hugovk
Copy link
Member

@hugovk hugovk commented Dec 7, 2024

error: Name state is not defined [name-defined]
error: Cannot find implementation or library stub for module named _colorize  [import-not-found]
Copy link
Member

@sobolevn sobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to test this? We have https://github.com/python/cpython/blob/main/Lib/test/test_regrtest.py file where this might fit.

@hugovk
Copy link
Member Author

hugovk commented Dec 9, 2024

I've added some tests.

Copy link
Member

@sobolevn sobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

Copy link
Member

@Eclips4 Eclips4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Thank you Hugo for coloring unittest and our test suite!

@hugovk hugovk merged commit 212448b into python:main Dec 10, 2024
50 checks passed
@hugovk hugovk deleted the 3.14-regrtest-colour branch December 10, 2024 07:44
srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this pull request Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants