Skip to content

gh-127864: Fix compiler warning (-Wstringop-truncation) #127878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 16, 2024
Merged

gh-127864: Fix compiler warning (-Wstringop-truncation) #127878

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
deaf570
Fix compiler warning (-Wstringop-truncation)
tomasr8 Dec 12, 2024
4c8cf6a
Use memcpy in both places
tomasr8 Dec 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Python/import.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1176,7 +1176,7 @@ hashtable_key_from_2_strings(PyObject *str1, PyObject *str2, const char sep)
return NULL;
}

strncpy(key, str1_data, str1_len);
memcpy(key, str1_data, str1_len);
key[str1_len] = sep;
strncpy(key + str1_len + 1, str2_data, str2_len + 1);
assert(strlen(key) == size - 1);
Expand Down
Loading