Skip to content

gh-121621: clear running loop early in asyncio #128004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Dec 18, 2024
Merged

gh-121621: clear running loop early in asyncio #128004

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
1ad2089
clear running loop early
kumaraditya303 Dec 16, 2024
5801138
add back clearing in PyThreadState_Clear
kumaraditya303 Dec 16, 2024
5222bb6
add comment
kumaraditya303 Dec 17, 2024
e0147c6
Update Modules/_asynciomodule.c
kumaraditya303 Dec 18, 2024
66bcb32
Merge branch 'main' into clear-ts
kumaraditya303 Dec 18, 2024
32486ae
Merge branch 'main' into clear-ts
kumaraditya303 Dec 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions Modules/_asynciomodule.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3723,6 +3723,11 @@ module_clear(PyObject *mod)
Py_CLEAR(state->iscoroutine_typecache);

Py_CLEAR(state->context_kwname);
// Clear the ref to running loop so that finalizers can run early.
// If there are other running loops in different threads,
// those get cleared in PyThreadState_Clear.
_PyThreadStateImpl *ts = (_PyThreadStateImpl *)_PyThreadState_GET();
Py_CLEAR(ts->asyncio_running_loop);

return 0;
}
Expand Down
Loading