Skip to content

gh-128066: Fixed PyREPL history saving on read-only file systems #128088

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 7 commits into from
Closed

gh-128066: Fixed PyREPL history saving on read-only file systems #128088

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
c2d39dd
Fixed pyrepl history saving on read-only file systems
vladimir-poghosyan Dec 19, 2024
0da307d
Added NEWS.d entry
vladimir-poghosyan Dec 19, 2024
2434c4f
Merge branch 'python:main' into fix-issue-128066
vladimir-poghosyan Dec 20, 2024
9bc8ef5
Improved warning message during pyrepl history saving
vladimir-poghosyan Apr 11, 2025
9b65418
Merge branch 'main' into fix-issue-128066
vladimir-poghosyan Apr 11, 2025
e1a74c5
Reverted changes for writing pyrepl history file
vladimir-poghosyan Apr 11, 2025
090ca57
Added warning on failing to write REPL history file at exit
vladimir-poghosyan Apr 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions Lib/_pyrepl/readline.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -450,8 +450,14 @@ def read_history_file(self, filename: str = gethistoryfile()) -> None:
def write_history_file(self, filename: str = gethistoryfile()) -> None:
maxlength = self.saved_history_length
history = self.get_reader().get_trimmed_history(maxlength)
f = open(os.path.expanduser(filename), "w",
encoding="utf-8", newline="\n")

try:
f = open(os.path.expanduser(filename), "w",
encoding="utf-8", newline="\n")
except OSError as e:
warnings.warn(f"failed to open the history file: {e}")
return

with f:
for entry in history:
entry = entry.replace("\n", "\r\n") # multiline history support
Expand Down
1 change: 1 addition & 0 deletions Misc/NEWS.d/next/Library/2024-12-19-07-27-52.gh-issue-128066.85NlMB.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fixed pyrepl history saving on read-only file systems.
Loading