gh-124111: Fix TCL 9 threaded detection #128103
Open
+4
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All commit authors signed the Contributor License Agreement. |
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
4 tasks
Wulian233
approved these changes
Dec 20, 2024
ZeroIntensity
added
topic-tkinter
needs backport to 3.12
|
@cho-m Please can you add a news file? See #128103 (comment). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original threaded detection doesn't work with TCL 9. Instead setting to always enable threaded based on release note for TCL 9+
https://sourceforge.net/projects/tcl/files/Tcl/9.0.0/tcl-release-notes-9.0.0.md/download:
Notes
gh-124111as it was for general TCL 9 support (similarly piggy-backing off NEWS blurb as wasn't in stable release). Could create a separate issue/blurb if preferred.TCL_MAJOR_VERSIONas original logic was for looking for threaded in TCL. Could checkTK_MAJOR_VERSIONinstead as the major versions should be the same.