Skip to content

[3.13] gh-128030: Avoid error from PyModule_GetFilenameObject for non-module (GH-128047) #128114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 20, 2024
Merged

[3.13] gh-128030: Avoid error from PyModule_GetFilenameObject for non-module (GH-128047) #128114

merged 1 commit into from
Dec 20, 2024

Conversation

@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Dec 20, 2024 •
edited by bedevere-app bot
Loading

I missed the extra PyModule_Check in GH-127660 because I was looking at
3.12 as the base implementation for import from. This meant that I
missed the PyModuleCheck introduced in GH-112661.
(cherry picked from commit 45e6dd6)

Co-authored-by: Shantanu [email protected]

@hauntsaninja @miss-islington
pythongh-128030: Avoid error from PyModule_GetFilenameObject for non-…
76b88e6 
…module (pythonGH-128047)

I missed the extra `PyModule_Check` in pythonGH-127660 because I was looking at
3.12 as the base implementation for import from. This meant that I
missed the `PyModuleCheck` introduced in pythonGH-112661.
(cherry picked from commit 45e6dd6)

Co-authored-by: Shantanu <[email protected]>
This was referenced Dec 20, 2024
Closed
Merged
@hauntsaninja hauntsaninja enabled auto-merge (squash) December 20, 2024 08:23
@hauntsaninja hauntsaninja merged commit f320f74 into python:3.13 Dec 20, 2024
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brettcannon brettcannon Awaiting requested review from brettcannon brettcannon is a code owner

@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner

@ncoghlan ncoghlan Awaiting requested review from ncoghlan ncoghlan is a code owner

@warsaw warsaw Awaiting requested review from warsaw warsaw is a code owner

@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@miss-islington @hauntsaninja