Clean up redundant ifdef in list getitem #128257
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's already inside a `Py_GIL_DISABLED` block so the `#else` clause is always unused.
picnixz
approved these changes
Dec 25, 2024
ZeroIntensity
approved these changes
Dec 25, 2024
StanFromIreland
approved these changes
Dec 25, 2024
kumaraditya303
approved these changes
Dec 26, 2024
|
Thanks @da-woods for the PR, and @kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Dec 26, 2024
It's already inside a `Py_GIL_DISABLED` block so the `#else` clause is always unused. (cherry picked from commit 42f7a00) Co-authored-by: da-woods <[email protected]>
|
GH-128276 is a backport of this pull request to the 3.13 branch. |
kumaraditya303
pushed a commit
that referenced
this pull request
Dec 26, 2024
Clean up redundant ifdef in list getitem (GH-128257) It's already inside a `Py_GIL_DISABLED` block so the `#else` clause is always unused. (cherry picked from commit 42f7a00) Co-authored-by: da-woods <[email protected]>
srinivasreddy
pushed a commit
to srinivasreddy/cpython
that referenced
this pull request
Jan 8, 2025
It's already inside a `Py_GIL_DISABLED` block so the `#else` clause is always unused.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's already inside a
Py_GIL_DISABLEDblock so the#elseclause is always unused.(Tiny cleanup so hopefully doesn't need an issue or news)