gh-125170: Hard deprecate PyEval_GetLocals in 3.14
#128348
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Misc/NEWS.d/next/C_API/2024-12-30-15-45-37.gh-issue-125170.Jdo8RC.rst
Outdated
Show resolved
Hide resolved
|
All commit authors signed the Contributor License Agreement. |
xuantengh
force-pushed
the
deprecate-getlocals
branch
2 times, most recently
from
04e97fb to
36c1cd0
Compare
Python/ceval.c
Outdated
Comment on lines
2602
to
2604
| if (PyErr_WarnEx(PyExc_DeprecationWarning, | ||
| "PyEval_GetLocals() is deprecated in Python 3.14 " | ||
| "and will be removed in 3.16.", 1)) { |
There was a problem hiding this comment.
This is the convention for us:
Suggested change
| if (PyErr_WarnEx(PyExc_DeprecationWarning, | |
| "PyEval_GetLocals() is deprecated in Python 3.14 " | |
| "and will be removed in 3.16.", 1)) { | |
| if (PyErr_WarnEx(PyExc_DeprecationWarning, | |
| "PyEval_GetLocals() is deprecated in Python 3.14 " | |
| "and will be removed in 3.16.", 1) < 0) { |
|
I don't think we ever reached to a conclusion on whether/how/when we deprecate this API. @ncoghlan @markshannon |
xuantengh
force-pushed
the
deprecate-getlocals
branch
from
0460320 to
0c4e6b5
Compare
xuantengh
force-pushed
the
deprecate-getlocals
branch
from
0c4e6b5 to
5ace717
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to hard deprecate the
PyEval_GetLocalsAPI by emitting a deprecated warning. Meanwhile, this also removes the corresponding tests for the API.If we consider to deprecate
PyFrame_FastToLocalsandPyFrame_FastToLocalsWithErroras well (mentioned in #125170 (comment)), please let me know. I think they can be done together in this PR.PyEval_GetLocals()#125170