Skip to content

gh-128377: Fix test_cmd_line.test_non_interactive_output_buffering fail with PYTHONUNBUFFERED=1 #128378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jan 12, 2025
Merged

gh-128377: Fix test_cmd_line.test_non_interactive_output_buffering fail with PYTHONUNBUFFERED=1 #128378

Changes from 3 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
565f15c
Fix `test_cmd_line.test_non_interactive_output_buffering` fail with `…
WolframAlph Dec 31, 2024
7ff7de3
Use get if `PYTHONUNBUFFERED` is not defined`
WolframAlph Dec 31, 2024
a42798d
Use `EnvironmentVarGuard` to set `PYTHONUNBUFFERED`
WolframAlph Jan 1, 2025
6bc56b8
use unittest.skipIf
WolframAlph Jan 2, 2025
c13851c
fix spaces
WolframAlph Jan 2, 2025
db3031a
add line break
WolframAlph Jan 2, 2025
9aa5866
fix lint
WolframAlph Jan 2, 2025
cf6f0fc
fix alignment
WolframAlph Jan 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 16 additions & 13 deletions Lib/test/test_cmd_line.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -337,19 +337,22 @@ def test_osx_android_utf8(self):
self.assertEqual(p.returncode, 0)

def test_non_interactive_output_buffering(self):
code = textwrap.dedent("""
import sys
out = sys.stdout
print(out.isatty(), out.write_through, out.line_buffering)
err = sys.stderr
print(err.isatty(), err.write_through, err.line_buffering)
""")
args = [sys.executable, '-c', code]
proc = subprocess.run(args, stdout=subprocess.PIPE,
stderr=subprocess.PIPE, text=True, check=True)
self.assertEqual(proc.stdout,
'False False False\n'
'False False True\n')
with os_helper.EnvironmentVarGuard() as environ:
# we expect buffered stdio
environ["PYTHONUNBUFFERED"] = "0"
code = textwrap.dedent("""
import sys
out = sys.stdout
print(out.isatty(), out.write_through, out.line_buffering)
err = sys.stderr
print(err.isatty(), err.write_through, err.line_buffering)
""")
args = [sys.executable, '-c', code]
proc = subprocess.run(args, stdout=subprocess.PIPE,
stderr=subprocess.PIPE, text=True, check=True)
self.assertEqual(proc.stdout,
'False False False\n'
'False False True\n')

def test_unbuffered_output(self):
# Test expected operation of the '-u' switch
Expand Down
Loading