- 
          
- 
                Notifications
    You must be signed in to change notification settings 
- Fork 33.3k
          gh-128456: Use -reorder-functions=cdsort for BOLT
          #128457
        
          New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
    
                
     Merged
            
            
          Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    `hfsort+` is deprecated
| I don't believe this needs a news entry. | 
              
                    erlend-aasland
  
              
              approved these changes
              
                  
                    Jan 3, 2025 
                  
              
              
            
            
      
        
              This comment was marked as outdated.
        
        
      
    
  This comment was marked as outdated.
      
        
              This comment was marked as outdated.
        
        
      
    
  This comment was marked as outdated.
    
  miss-islington 
      pushed a commit
        to miss-islington/cpython
      that referenced
      this pull request
    
      Jan 3, 2025 
    
    
      
  
    
      
    
  
…honGH-128457) 'hfsort+' is deprecated in favor of 'cdsort'. (cherry picked from commit 4974bbd) Co-authored-by: Zanie Blue <[email protected]>
| GH-128461 is a backport of this pull request to the 3.13 branch. | 
    
  miss-islington 
      pushed a commit
        to miss-islington/cpython
      that referenced
      this pull request
    
      Jan 3, 2025 
    
    
      
  
    
      
    
  
…honGH-128457) 'hfsort+' is deprecated in favor of 'cdsort'. (cherry picked from commit 4974bbd) Co-authored-by: Zanie Blue <[email protected]>
| GH-128462 is a backport of this pull request to the 3.12 branch. | 
    
  erlend-aasland 
      pushed a commit
      that referenced
      this pull request
    
      Jan 3, 2025 
    
    
      
  
    
      
    
  
…-128457) (#128462) 'hfsort+' is deprecated in favor of 'cdsort'. (cherry picked from commit 4974bbd) Co-authored-by: Zanie Blue <[email protected]>
    
  erlend-aasland 
      pushed a commit
      that referenced
      this pull request
    
      Jan 3, 2025 
    
    
      
  
    
      
    
  
…-128457) (#128461) 'hfsort+' is deprecated in favor of 'cdsort'. (cherry picked from commit 4974bbd) Co-authored-by: Zanie Blue <[email protected]>
| Just as a note, per the comment at #124948 (comment), this has no effect but silencing the deprecation warning as " | 
    
  WolframAlph 
      pushed a commit
        to WolframAlph/cpython
      that referenced
      this pull request
    
      Jan 4, 2025 
    
    
      
  
    
      
    
  
…hon#128457) 'hfsort+' is deprecated in favor of 'cdsort'.
    
  srinivasreddy 
      pushed a commit
        to srinivasreddy/cpython
      that referenced
      this pull request
    
      Jan 8, 2025 
    
    
      
  
    
      
    
  
…hon#128457) 'hfsort+' is deprecated in favor of 'cdsort'.
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
hfsort+is deprecated. See llvm/llvm-project#72408-reorder-functions=hfsort+#128456