Skip to content

gh-127073: Clear completion list when KeyboardInterrupt occurs in REPL #128467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Natural-selection1 wants to merge 7 commits into
base: main
Choose a base branch
from
Draft

gh-127073: Clear completion list when KeyboardInterrupt occurs in REPL #128467

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
4e75c2a
Clear completion list when KeyboardInterrupt occurs
Natural-selection1 Jan 4, 2025
cbe2f11
📜🤖 Added by blurb_it.
blurb-it[bot] Jan 4, 2025
59c1cc1
Merge branch 'main' into clean_suggestion
Natural-selection1 Jan 5, 2025
1ab7f52
Merge branch 'python:main' into clean_suggestion
Natural-selection1 Jan 7, 2025
9801a10
Merge branch 'python:main' into clean_suggestion
Natural-selection1 Jan 7, 2025
95233ba
Merge branch 'python:main' into clean_suggestion
Natural-selection1 Mar 22, 2025
7089258
Merge branch 'python:main' into clean_suggestion
Natural-selection1 Mar 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions Lib/_pyrepl/simple_interact.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,6 +164,8 @@ def maybe_run_command(statement: str) -> bool:
r = _get_reader()
if r.input_trans is r.isearch_trans:
r.do_cmd(("isearch-end", [""]))
if r.cmpltn_menu_choices:
r.cmpltn_reset()
r.pos = len(r.get_unicode())
r.dirty = True
r.refresh()
Expand Down
4 changes: 4 additions & 0 deletions Misc/NEWS.d/next/Tools-Demos/2025-01-04-01-45-19.gh-issue-127073.r8-flH.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
Previously in the REPL, when a completion list was displayed and KeyboardInterrupt
Copy link
Member

@ZeroIntensity ZeroIntensity Jan 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love the effort, but this is too long. Can we shorten this to a single sentence? (We don't need technical details, just what was fixed.)

was triggered using Ctrl+C, the completion list would persist and duplicate with
each KeyboardInterrupt. Now, when KeyboardInterrupt occurs, the completion list
is properly cleared, consistent with the behavior of other errors.
Loading