Skip to content

Conversation

@WolframAlph
Copy link
Contributor

@WolframAlph WolframAlph commented Jan 4, 2025

@WolframAlph WolframAlph requested a review from picnixz January 8, 2025 11:43
@WolframAlph WolframAlph requested a review from picnixz January 14, 2025 12:05
@picnixz
Copy link
Member

picnixz commented Jan 14, 2025

@vstinner: I plan to merge this with the following title:

Use `EnvironmentVarGuard` for `test_{builtin,io,locale}.py`

And the following commit message:

Modifying locale-related environment variables in `Lib/test/test_builtin.py`,
`Lib/test/test_io.py` and `Lib/test/test_locale.py` is now achieved by using
an `EnvironmentVarGuard` context instead of an explicit `try-finally` block.

Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@picnixz picnixz merged commit ae7f621 into python:main Jan 15, 2025
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants