Skip to content

gh-128562: Fix tkinter widget instance name sometimes duplicated on inherited class #128604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Jan 13, 2025
Merged

gh-128562: Fix tkinter widget instance name sometimes duplicated on inherited class #128604

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
37a36a1
fix: Fixed a bug with auto-naming
Xiaokang2022 Jan 8, 2025
b46da92
📜🤖 Added by blurb_it.
blurb-it[bot] Jan 8, 2025
2478aa4
refactor: Refactor the solution
Xiaokang2022 Jan 10, 2025
d0c90b7
fix: Use the better solution
Xiaokang2022 Jan 10, 2025
2e68dec
test: Add tests
Xiaokang2022 Jan 10, 2025
8353a11
fix
Xiaokang2022 Jan 10, 2025
4e9d5f1
Change "$" to "!"
Xiaokang2022 Jan 13, 2025
30e1ee3
Improve some tests
Xiaokang2022 Jan 13, 2025
078c5fc
Update Lib/test/test_tkinter/test_misc.py
Xiaokang2022 Jan 13, 2025
60b162a
Improve the test
Xiaokang2022 Jan 13, 2025
70f1f23
Update Misc/NEWS.d/next/Library/2025-01-08-03-09-29.gh-issue-128562.M…
serhiy-storchaka Jan 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions Lib/test/test_tkinter/test_misc.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,11 +37,15 @@ class Button2(tkinter.Button):
t = tkinter.Toplevel(self.root)
f = tkinter.Frame(t)
f2 = tkinter.Frame(t)
self.assertNotEqual(str(f), str(f2))
b = tkinter.Button(f2)
b2 = Button2(f2)
for name in str(b).split('.') + str(b2).split('.'):
self.assertFalse(name.isidentifier(), msg=repr(name))
self.assertEqual(str(b2)[-1], "!")
b3 = tkinter.Button(f2)
b4 = Button2(f2)
self.assertEqual(len(set([str(b), str(b2), str(b3), str(b4)])), 4)

@requires_tk(8, 6, 6)
def test_tk_busy(self):
Expand Down
Loading