Skip to content

gh-128691: Use deferred reference counting on _thread._local #128693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 10, 2025
Merged

gh-128691: Use deferred reference counting on _thread._local #128693

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a8c2e44
gh-128691: Use deferred reference counting on `_thread._local`
colesbury Jan 9, 2025
a0bcabc
Move _PyObject_SetDeferredRefcount call up
colesbury Jan 10, 2025
2a328af
Merge branch 'main' into gh-128691-thread-local-deferred
colesbury Jan 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions Modules/_threadmodule.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1414,6 +1414,10 @@ local_new(PyTypeObject *type, PyObject *args, PyObject *kw)
return NULL;
}

// gh-128691: Use deferred reference counting for thread-locals to avoid
// contention on the shared object.
_PyObject_SetDeferredRefcount((PyObject *)self);

self->args = Py_XNewRef(args);
self->kw = Py_XNewRef(kw);

Expand Down
Loading