Skip to content

gh-118761: substitute re import in base64.b16decode for a more efficient alternative #128736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jan 14, 2025
+15 −2
Merged

gh-118761: substitute re import in base64.b16decode for a more efficient alternative #128736

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
3a92fce
Improve import time of the `base64` module.
picnixz Jan 10, 2025
0b52712
blurb
picnixz Jan 10, 2025
d7b6253
Improve `base64.b16decode()` by a factor 10.
picnixz Jan 13, 2025
9e8fe5d
update NEWS
picnixz Jan 13, 2025
5be6178
Update Misc/NEWS.d/next/Library/2025-01-10-13-06-54.gh-issue-118761.f…
picnixz Jan 13, 2025
b36d915
add What's New entry
picnixz Jan 14, 2025
5562c81
Update Doc/whatsnew/3.14.rst
picnixz Jan 14, 2025
82d18d7
Update Misc/NEWS.d/next/Library/2025-01-10-13-06-54.gh-issue-118761.f…
picnixz Jan 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions Lib/base64.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
# Modified 30-Dec-2003 by Barry Warsaw to add full RFC 3548 support
# Modified 22-May-2007 by Guido van Rossum to use bytes everywhere

import re
import struct
import binascii

Expand Down Expand Up @@ -284,7 +283,7 @@ def b16decode(s, casefold=False):
s = _bytes_from_decode_data(s)
if casefold:
s = s.upper()
if re.search(b'[^0-9A-F]', s):
if s.translate(None, delete=b'0123456789ABCDEF'):
raise binascii.Error('Non-base16 digit found')
return binascii.unhexlify(s)

Expand Down
4 changes: 4 additions & 0 deletions Misc/NEWS.d/next/Library/2025-01-10-13-06-54.gh-issue-118761.f8oADD.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
Improve performance of :func:`base64.b16decode` by a factor ten by
removing an un-necessary regular expression. Consequently, :mod:`re`
is no more implicitly available as ``base64.re`` and import time of
:mod:`base64` is improved by a factor six. Patch by Bénédikt Tran.
Loading