Skip to content

gh-128759: fix data race in type_modified_unlocked #128764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 13, 2025
Merged

gh-128759: fix data race in type_modified_unlocked #128764

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a767905
gh-128759: fix data race in `type_modified_unlocked`
sobolevn Jan 12, 2025
39f1870
Update Objects/typeobject.c
sobolevn Jan 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Objects/typeobject.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1038,7 +1038,7 @@ type_modified_unlocked(PyTypeObject *type)
We don't assign new version tags eagerly, but only as
needed.
*/
if (type->tp_version_tag == 0) {
if (FT_ATOMIC_LOAD_UINT32_RELAXED(type->tp_version_tag) == 0) {
return;
}
// Cannot modify static builtin types.
Expand Down
Loading