Skip to content

gh-67206: document that string.printable is not printable in the POSIX sense #128820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jan 14, 2025
Merged

gh-67206: document that string.printable is not printable in the POSIX sense #128820

merged 6 commits into from
Jan 14, 2025

Conversation

@picnixz
Copy link
Member

@picnixz picnixz commented Jan 14, 2025 •
edited by github-actions bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request Jan 14, 2025
Closed
@bedevere-app bedevere-app bot added docs Documentation in the Doc dir awaiting core review labels Jan 14, 2025
@picnixz picnixz requested review from bitdancer and vstinner January 14, 2025 10:12
@picnixz picnixz changed the title gh-67206: document that string.printable is not printable in sense of POSIX and RFC 8522 gh-67206: document that string.printable is not printable in the sense of POSIX and RFC 8522 Jan 14, 2025
vstinner
vstinner reviewed Jan 14, 2025
View reviewed changes
@picnixz picnixz changed the title gh-67206: document that string.printable is not printable in the sense of POSIX and RFC 8522 gh-67206: document that string.printable is not printable in the sense of POSIX and RFC 1522 Jan 14, 2025
@picnixz picnixz changed the title gh-67206: document that string.printable is not printable in the sense of POSIX and RFC 1522 gh-67206: document that string.printable is not printable in the sense of POSIX and RFC Jan 14, 2025
@picnixz picnixz changed the title gh-67206: document that string.printable is not printable in the sense of POSIX and RFC gh-67206: document that string.printable is not printable in the POSIX sense Jan 14, 2025
@picnixz picnixz requested a review from vstinner January 14, 2025 15:46
vstinner
vstinner approved these changes Jan 14, 2025
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@picnixz
Copy link
Member Author

picnixz commented Jan 14, 2025 •
edited
Loading

I will reuse the title of the PR as the commit title and use an empty body message (it's easier to read the diff in this case)

@picnixz picnixz merged commit d906bde into python:main Jan 14, 2025
29 checks passed
@picnixz picnixz deleted the doc/string/is-printable-67206 branch January 14, 2025 16:07
@picnixz picnixz added needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes labels Jan 14, 2025
@miss-islington-app
Copy link

Thanks @picnixz for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Thanks @picnixz for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

@picnixz picnixz removed the needs backport to 3.13 bugs and security fixes label Jan 14, 2025
@vstinner vstinner added the needs backport to 3.13 bugs and security fixes label Jan 14, 2025
@miss-islington-app
Copy link

Thanks @picnixz for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Thanks @picnixz for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

@vstinner vstinner added needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes and removed needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes labels Jan 15, 2025
@miss-islington-app
Copy link

Thanks @picnixz for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Thanks @picnixz for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

@ambv ambv added needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes and removed needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes labels Jan 15, 2025
@miss-islington-app
Copy link

Thanks @picnixz for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Thanks @picnixz for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 15, 2025
@picnixz @miss-islington
pythongh-67206: Document that string.printable is not printable in …
096833a 
…the POSIX sense (pythonGH-128820)

(cherry picked from commit d906bde)

Co-authored-by: Bénédikt Tran <[email protected]>
@ambv ambv added needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes and removed needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes labels Jan 15, 2025
@miss-islington-app
Copy link

Thanks @picnixz for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Thanks @picnixz for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 15, 2025
@picnixz @miss-islington
pythongh-67206: Document that string.printable is not printable in …
2b4f89a 
…the POSIX sense (pythonGH-128820)

(cherry picked from commit d906bde)

Co-authored-by: Bénédikt Tran <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Jan 15, 2025

GH-128867 is a backport of this pull request to the 3.12 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 15, 2025
@picnixz @miss-islington
pythongh-67206: Document that string.printable is not printable in …
25c2d15 
…the POSIX sense (pythonGH-128820)

(cherry picked from commit d906bde)

Co-authored-by: Bénédikt Tran <[email protected]>
@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Jan 15, 2025
@bedevere-app
Copy link

bedevere-app bot commented Jan 15, 2025

GH-128868 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Jan 15, 2025
picnixz added a commit that referenced this pull request Jan 15, 2025
@miss-islington @picnixz
[3.13] gh-67206: Document that string.printable is not printable in…
639e0f3 
… the POSIX sense (GH-128820) (#128868)

gh-67206: Document that `string.printable` is not printable in the POSIX sense (GH-128820)
(cherry picked from commit d906bde)

Co-authored-by: Bénédikt Tran <[email protected]>
picnixz added a commit that referenced this pull request Jan 15, 2025
@miss-islington @picnixz
[3.12] gh-67206: Document that string.printable is not printable in…
85255c4 
… the POSIX sense (GH-128820) (#128867)

gh-67206: Document that `string.printable` is not printable in the POSIX sense (GH-128820)
(cherry picked from commit d906bde)

Co-authored-by: Bénédikt Tran <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes

@bitdancer bitdancer Awaiting requested review from bitdancer

Assignees

@picnixz picnixz

Labels

docs Documentation in the Doc dir

Projects

Docs PRs
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@picnixz @vstinner @ambv