Skip to content

GH-128682: Convert explicit loops closing arrays into DECREF_INPUTS. #128822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 14, 2025
Merged

GH-128682: Convert explicit loops closing arrays into DECREF_INPUTS. #128822

merged 2 commits into from
Jan 14, 2025

Conversation

markshannon
Copy link
Member

@markshannon markshannon commented Jan 14, 2025 •
edited by bedevere-app bot
Loading

This PR makes the handling of escaping calls in the code generator more robust by:

  • handling array inputs with DECREF_INPUTS
  • Making it explicit that Py_DECREF and Py_XDECREF escape.

@bedevere-app bedevere-app bot mentioned this pull request Jan 14, 2025
Open
@markshannon markshannon merged commit f49a1df into python:main Jan 14, 2025
71 checks passed
@markshannon markshannon deleted the escaping-decref-2 branch January 14, 2025 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iritkatriel iritkatriel iritkatriel approved these changes

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@markshannon @iritkatriel