Skip to content

gh-128514: Enable -split-all-cold for BOLT #128850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

gh-128514: Enable -split-all-cold for BOLT #128850

wants to merge 2 commits into from

Conversation

@zanieb
Copy link
Contributor

@zanieb zanieb commented Jan 14, 2025 •
edited
Loading

See the linked issue for benchmarking.

@bedevere-app bedevere-app bot mentioned this pull request Jan 14, 2025
Open
@zanieb zanieb force-pushed the zb/bolt-split-all-cold branch from 8ee353e to 0c7711c Compare January 14, 2025 23:42
@corona10 corona10 self-assigned this Jan 15, 2025
@corona10
Copy link
Member

  • 1% performance gain looks good
  • Just please double check that it always guarantees the 1% gain to sure that it is not noise :)

@zanieb
Copy link
Contributor Author

zanieb commented Jan 15, 2025

I'll take these out of draft once I repeat the benchmarks and the CI is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erlend-aasland erlend-aasland Awaiting requested review from erlend-aasland erlend-aasland will be requested when the pull request is marked ready for review erlend-aasland is a code owner

@corona10 corona10 Awaiting requested review from corona10 corona10 will be requested when the pull request is marked ready for review corona10 is a code owner

@AA-Turner AA-Turner Awaiting requested review from AA-Turner AA-Turner will be requested when the pull request is marked ready for review AA-Turner is a code owner

@emmatyping emmatyping Awaiting requested review from emmatyping emmatyping will be requested when the pull request is marked ready for review emmatyping is a code owner

Assignees

@corona10 corona10

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@zanieb @corona10