Skip to content

Align error message of _pyio.TextIOWrapper.seek with its C implementation #128852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Align error message of _pyio.TextIOWrapper.seek with its C implementation #128852

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
c8faf57
Update _pyio.py
DimmaDont Jan 15, 2025
f402966
Merge branch 'python:main' into pyio-textiowrapper-seek
DimmaDont Jan 15, 2025
266aa5a
Update _pyio.py
DimmaDont Jan 15, 2025
22b1e42
Merge branch 'python:main' into pyio-textiowrapper-seek
DimmaDont Jan 16, 2025
c3e9b9f
Create 2025-01-15-23-51-44.gh-issue-128852.89wrex.rst
DimmaDont Jan 16, 2025
0ef41a0
Update 2025-01-15-23-51-44.gh-issue-128852.89wrex.rst
DimmaDont Jan 17, 2025
2531ccf
Update Misc/NEWS.d/next/Library/2025-01-15-23-51-44.gh-issue-128852.8…
DimmaDont Jan 17, 2025
334f843
Update _pyio.py
DimmaDont Jan 17, 2025
6af14b8
Update 2025-01-15-23-51-44.gh-issue-128852.89wrex.rst
DimmaDont Jan 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Lib/_pyio.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2458,6 +2458,8 @@ def detach(self):
return buffer

def seek(self, cookie, whence=0):
self._checkClosed()

def _reset_encoder(position):
"""Reset the encoder (merely useful for proper BOM handling)"""
try:
Expand All @@ -2471,8 +2473,6 @@ def _reset_encoder(position):
else:
encoder.reset()

if self.closed:
raise ValueError("tell on closed file")
if not self._seekable:
raise UnsupportedOperation("underlying stream is not seekable")
if whence == SEEK_CUR:
Expand Down
2 changes: 2 additions & 0 deletions Misc/NEWS.d/next/Library/2025-01-15-23-51-44.gh-issue-128852.89wrex.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
Align ``_pyio.TextIOWrapper.seek``'s file closed check with its C
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's keep the technical details out of it. Could you say something about the error message?

implementation
Loading