Skip to content

gh-128703: Fix mimetypes.guess_type for empty Content-Type in registry #128854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 14, 2025
Merged

gh-128703: Fix mimetypes.guess_type for empty Content-Type in registry #128854

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a2c92e8
Fix guess_type defalut behavior
rruuaanng Jan 15, 2025
a679ffe
Apply Steve advice
rruuaanng Jan 21, 2025
628fe3b
Change NEWS
rruuaanng Feb 14, 2025
dca4e8b
Merge branch 'main' into fix-webp-type
rruuaanng Feb 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions Lib/mimetypes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,8 @@ def add_type(self, type, ext, strict=True):
list of standard types, else to the list of non-standard
types.
"""
if not type:
return
self.types_map[strict][ext] = type
exts = self.types_map_inv[strict].setdefault(type, [])
if ext not in exts:
Expand Down
2 changes: 2 additions & 0 deletions Misc/NEWS.d/next/Library/2025-01-15-12-04-30.gh-issue-128703.6WPf38.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
Fix :meth:`mimetypes.MimeTypes.guess_type` to use default mapping for empty
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We document this as a function:

Suggested change
Fix :meth:`mimetypes.MimeTypes.guess_type` to use default mapping for empty
Fix :func:`mimetypes.guess_type` to use default mapping for empty

(I think that's right, but check the output of the docs build if it fails again.)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I just saw it. But, to be honest, I often can't tell which label to use for symbol references.

``Content-Type`` in registry.
Loading