[3.12] gh-128916: Do not set SO_REUSEPORT on non-AF_INET* sockets (GH-128933)
#128970
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ythonGH-128933) * pythongh-128916: Do not set `SO_REUSEPORT` on non-`AF_INET*` sockets Do not attempt to set ``SO_REUSEPORT`` on sockets of address familifies other than ``AF_INET`` and ``AF_INET6``, as it is meaningless with these address families, and the call with fail with Linux kernel 6.12.9 and newer. * Apply suggestions from code review Co-authored-by: Vinay Sajip <[email protected]> --------- (cherry picked from commit 3829104) Co-authored-by: Michał Górny <[email protected]> Co-authored-by: Vinay Sajip <[email protected]>
miss-islington
requested review from
1st1,
asvetlov,
gvanrossum,
kumaraditya303 and
willingc
as code owners
This was referenced Jan 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
socketserver.Unix*Servermay attempt to setSO_REUSEPORTon Unix sockets, causingEOPNOTSUPP, e.g. intest_asyncio#128916: Do not setSO_REUSEPORTon non-AF_INET*socketsDo not attempt to set
SO_REUSEPORTon sockets of address familifies otherthan
AF_INETandAF_INET6, as it is meaningless with these addressfamilies, and the call with fail with Linux kernel 6.12.9 and newer.
Co-authored-by: Vinay Sajip [email protected]
(cherry picked from commit 3829104)
Co-authored-by: Michał Górny [email protected]
Co-authored-by: Vinay Sajip [email protected]