gh-129173: Use _PyUnicodeError_GetParams in PyCodec_SurrogatePassErrors
#129134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
picnixz
commented
Jan 21, 2025
picnixz
commented
Jan 21, 2025
picnixz
changed the title
_PyUnicodeError_GetParams for the 'surrogate' handlers_PyUnicodeError_GetParams for the 'surrogate' handlers
picnixz
changed the title
_PyUnicodeError_GetParams for the 'surrogate' handlers_PyUnicodeError_GetParams in PyCodec_SurrogatePassErrors
|
There are a few post-edits I want to make but not today. Same for the remaining PR, so I'm keeping it as a draft. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently a draft as it depends on #129174.
_PyUnicodeError_GetParamsand extract complex logic into separate functions #129173