Skip to content

gh-129231: group executable JIT code in memory #129232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 2, 2025
Merged

gh-129231: group executable JIT code in memory #129232

merged 3 commits into from
Feb 2, 2025

Conversation

diegorusso
Copy link
Contributor

@diegorusso diegorusso commented Jan 23, 2025 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request Jan 23, 2025
Closed
@diegorusso
Copy link
Contributor Author

diegorusso commented Jan 23, 2025 •
edited
Loading

The change is not really tested as we need the -fplt flag on AArch64. Without this flag, clang-19 doesn't make use of the trampolines.
This is the branch that makes use of the fplt on AArch64 Linux: https://github.com/diegorusso/cpython/tree/fplt

We really need to get those changes first and then re-test this PR.

brandtbucher
brandtbucher approved these changes Jan 29, 2025
View reviewed changes
Copy link
Member

@brandtbucher brandtbucher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks! I appreciate that you reordered things to reflect the new layout. But I don't think the reordering makes as much sense in the StencilGroup struct, so can you leave that the way it was?

@brandtbucher brandtbucher merged commit a29a9c0 into python:main Feb 2, 2025
58 checks passed
srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this pull request Feb 7, 2025
@diegorusso @srinivasreddy
pythonGH-129231: Group executable JIT code in memory (pythonGH-129232)
0555ec9
@diegorusso diegorusso deleted the jit-layout branch April 4, 2025 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brandtbucher brandtbucher brandtbucher approved these changes

@savannahostrowski savannahostrowski Awaiting requested review from savannahostrowski savannahostrowski is a code owner

Assignees

No one assigned

Labels

topic-JIT

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@diegorusso @brandtbucher