Skip to content

gh-129271: Fix reference leak with unicode writer in fast path in the json module #129272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 25, 2025
Merged

gh-129271: Fix reference leak with unicode writer in fast path in the json module #129272

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d52f22e
gh-129271: Fix reference leak with unicode writer in fast path in the…
pablogsal Jan 25, 2025
e42dff2
fixup! gh-129271: Fix reference leak with unicode writer in fast path…
pablogsal Jan 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Modules/_json.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -413,6 +413,7 @@ scanstring_unicode(PyObject *pystr, Py_ssize_t end, int strict, Py_ssize_t *next
if (c == '"') {
// Fast path for simple case.
if (_PyUnicodeWriter_IsEmpty(writer)) {
PyUnicodeWriter_Discard(writer);
PyObject *ret = PyUnicode_Substring(pystr, end, next);
if (ret == NULL) {
goto bail;
Expand Down
Loading