Skip to content

gh-126332: Add tests for _pyrepl.utils #129325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Feb 21, 2025
Merged

gh-126332: Add tests for _pyrepl.utils #129325

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
07715bf
Add tests for _pyrepr.utils
eendebakpt Jan 26, 2025
3699678
📜🤖 Added by blurb_it.
blurb-it[bot] Jan 26, 2025
ab78d05
Merge branch 'main' into pyrepl_utils
eendebakpt Jan 27, 2025
8596419
Merge branch 'main' into pyrepl_utils
eendebakpt Feb 10, 2025
5ce442a
improve test
eendebakpt Feb 20, 2025
7bd56b9
Merge branch 'main' into pyrepl_utils
eendebakpt Feb 20, 2025
0782750
Merge branch 'main' into pyrepl_utils
vstinner Feb 21, 2025
b17710e
fix news entry name
eendebakpt Feb 21, 2025
deda6ad
Merge branch 'main' into pyrepl_utils
eendebakpt Feb 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions Lib/test/test_pyrepl/test_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
from unittest import TestCase

from _pyrepl.utils import str_width, wlen


class TestUtils(TestCase):
def test_str_width(self):
characters = ['a', '1', '_', '!', '\x1a', '\u263A', '\uffb9']
for c in characters:
self.assertEqual(str_width(c), 1)

characters = [chr(99989), chr(99999)]
for c in characters:
self.assertEqual(str_width(c), 2)

def test_wlen(self):
for c in ['a', 'b', '1', '!', '_']:
self.assertEqual(wlen(c), 1)
self.assertEqual(wlen('\x1a'), 2)

self.assertEqual(wlen('hello'), 5)
self.assertEqual(wlen('hello'+'\x1a'), 7)
self.assertEqual(wlen('hello'+'\0x1B'), 9)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test is strange. Are you testing the nul byte and then the string x1B on purpose?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. I tried to create a special unicode character to hit one of the paths in wlen, but think I made a typo. I removed this test and added two others.

1 change: 1 addition & 0 deletions Misc/NEWS.d/next/Library/2025-01-26-20-17-58.gh-issue-gh-126332.c0wUS-.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Add unit tests for pyrepl.
Loading