Skip to content

gh-129403: Fix ValueError Messages #129419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 30, 2025
Merged

gh-129403: Fix ValueError Messages #129419

merged 3 commits into from
Jan 30, 2025

Conversation

@StanFromIreland
Copy link
Member

@StanFromIreland StanFromIreland commented Jan 28, 2025 •
edited
Loading

All cases of this have been fixed confirmed by grep

grep -r "parties must be > 0"

@bedevere-app bedevere-app bot mentioned this pull request Jan 28, 2025
Closed
@StanFromIreland
Copy link
Member Author

Requesting Review @sobolevn

ZeroIntensity
ZeroIntensity reviewed Jan 29, 2025
View reviewed changes
Copy link
Member

@ZeroIntensity ZeroIntensity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's worth adding a blurb for this.

@StanFromIreland
Copy link
Member Author

@ZeroIntensity @sobolevn NEWS added.

ZeroIntensity
ZeroIntensity reviewed Jan 29, 2025
View reviewed changes
Copy link
Member

@ZeroIntensity ZeroIntensity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be worth adding an assertRaiseRegex test case, but I'm fine without it.

ZeroIntensity
ZeroIntensity approved these changes Jan 29, 2025
View reviewed changes
Copy link
Member

@ZeroIntensity ZeroIntensity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this, LGTM.

sobolevn
sobolevn approved these changes Jan 30, 2025
View reviewed changes
Copy link
Member

@sobolevn sobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! We generally don't backport the error message changes, but these ones were incorrect, so I treat them as bugs, so I will backport these changes.

@sobolevn sobolevn added needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes labels Jan 30, 2025
@sobolevn sobolevn merged commit bcb25d6 into python:main Jan 30, 2025
50 checks passed
@miss-islington-app
Copy link

Thanks @StanFromIreland for the PR, and @sobolevn for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 30, 2025
@StanFromIreland @ZeroIntensity @miss-islington
pythongh-129403: Fix ValueError messages in asyncio.Barrier and `…
5b88609 
…threading.Barrier` (pythonGH-129419)

(cherry picked from commit bcb25d6)

Co-authored-by: Stan Ulbrych <[email protected]>
Co-authored-by: Peter Bierma <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Jan 30, 2025

GH-129468 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Jan 30, 2025
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 30, 2025
@StanFromIreland @ZeroIntensity @miss-islington
pythongh-129403: Fix ValueError messages in asyncio.Barrier and `…
81065bb 
…threading.Barrier` (pythonGH-129419)

(cherry picked from commit bcb25d6)

Co-authored-by: Stan Ulbrych <[email protected]>
Co-authored-by: Peter Bierma <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Jan 30, 2025

GH-129469 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Jan 30, 2025
sobolevn pushed a commit that referenced this pull request Jan 30, 2025
@miss-islington @StanFromIreland @ZeroIntensity
[3.12] gh-129403: Fix ValueError messages in asyncio.Barrier and …
f463d05 
…`threading.Barrier` (GH-129419) (#129469)

gh-129403: Fix `ValueError` messages in `asyncio.Barrier` and `threading.Barrier` (GH-129419)
(cherry picked from commit bcb25d6)

Co-authored-by: Stan Ulbrych <[email protected]>
Co-authored-by: Peter Bierma <[email protected]>
sobolevn pushed a commit that referenced this pull request Jan 30, 2025
@miss-islington @StanFromIreland @ZeroIntensity
[3.13] gh-129403: Fix ValueError messages in asyncio.Barrier and …
ad4a141 
…`threading.Barrier` (GH-129419) (#129468)

gh-129403: Fix `ValueError` messages in `asyncio.Barrier` and `threading.Barrier` (GH-129419)
(cherry picked from commit bcb25d6)

Co-authored-by: Stan Ulbrych <[email protected]>
Co-authored-by: Peter Bierma <[email protected]>
srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this pull request Feb 7, 2025
@StanFromIreland @ZeroIntensity @srinivasreddy
pythongh-129403: Fix ValueError messages in asyncio.Barrier and `…
73f6a40 
…threading.Barrier` (python#129419)

Co-authored-by: Peter Bierma <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sobolevn sobolevn sobolevn approved these changes

@ZeroIntensity ZeroIntensity ZeroIntensity approved these changes

@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner

@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner

@kumaraditya303 kumaraditya303 Awaiting requested review from kumaraditya303 kumaraditya303 is a code owner

@willingc willingc Awaiting requested review from willingc willingc is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@StanFromIreland @sobolevn @ZeroIntensity