Skip to content

gh-129005: _pyio.BufferedIO remove copy on readall #129454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 30, 2025
Merged

gh-129005: _pyio.BufferedIO remove copy on readall #129454

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7e0f7ae
gh-129005: _pyio.BufferedIO remove copy on readall
cmaloney Jan 29, 2025
fe251e8
Update Misc/NEWS.d/next/Library/2025-01-29-00-00-01.gh-issue-129005.a…
vstinner Jan 30, 2025
8f52a54
Update Misc/NEWS.d/next/Library/2025-01-29-00-00-01.gh-issue-129005.a…
vstinner Jan 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions Lib/_pyio.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1062,6 +1062,9 @@ def _read_unlocked(self, n=None):
if chunk is None:
return buf[pos:] or None
else:
# Avoid slice + copy if there is no data in buf
if not buf:
return chunk
return buf[pos:] + chunk
chunks = [buf[pos:]] # Strip the consumed bytes.
current_size = 0
Expand Down
2 changes: 2 additions & 0 deletions Misc/NEWS.d/next/Library/2025-01-29-00-00-01.gh-issue-129005.aV_3O8.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
Remove an unnecessary copy when ``_pyio.BufferedReader.read`` is called to
read all data from a file and has no data already in buffer.
Loading