-
-
Couldn't load subscription status.
- Fork 33.2k
gh-129538: Fix IPv6Interface.ip losing scope ID information #129548
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
RafaelJohn9
wants to merge
10
commits into
python:main
Choose a base branch
from
RafaelJohn9:bugfix/issue-129538-scope-id
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+9
−1
Open
Changes from 7 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
63891cc
bugfix/issue-129538-scope-id
RafaelJohn9 9925248
📜🤖 Added by blurb_it.
blurb-it[bot] 8d167be
gh-129538: Fix: Removed comment showing the issue number
RafaelJohn9 962496d
Merge branch 'main' into bugfix/issue-129538-scope-id
RafaelJohn9 1f29c6c
Merge branch 'main' into bugfix/issue-129538-scope-id
RafaelJohn9 66d6f85
Fix: removed scope_id attr in IPV6Address clas
RafaelJohn9 5bdf7c2
Update: Fixed linting errors in .rst docs
RafaelJohn9 0744a66
Update Misc/NEWS.d/next/Library/2025-02-01-13-01-12.gh-issue-129538.A…
RafaelJohn9 1fccd55
Merge branch 'main' into bugfix/issue-129538-scope-id
RafaelJohn9 0577afd
Merge branch 'main' into bugfix/issue-129538-scope-id
RafaelJohn9 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
21 changes: 21 additions & 0 deletions
21
Misc/NEWS.d/next/Library/2025-02-01-13-01-12.gh-issue-129538.A9ERy9.rst
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| This pull request addresses the issue described in `issue #129538 <https://github.com/python/cpython/issues/129538>`_, where the ``IPv6Interface.ip`` loses the scope ID information when accessing the IP address. | ||
|
|
||
| The problem occurs when an IPv6 address with a scope ID is converted into an ``IPv6Interface`` and then accessed via the ``ip`` property, resulting in the loss of the scope ID information. This behavior is unexpected and not documented. | ||
|
|
||
| Minimal Example Demonstrating the Issue:: | ||
|
|
||
| addr = ipaddress.IPv6Address("fe80::%10") | ||
| addr_with_prefix = ipaddress.IPv6Interface((addr, 64)) | ||
| print(addr_with_prefix.ip) # Expected: IPv6Address('fe80::%10'), Actual: IPv6Address('fe80::') | ||
|
|
||
| Changes Made: | ||
| 1. Fix in ``IPv6Interface`` Class: | ||
| - Updated the ``IPv6Interface`` class to ensure the scope ID is preserved when converting the IP address. | ||
| - Modified the ``ip`` property to include the scope ID in the address string. | ||
|
|
||
| 2. Added Test Case: | ||
| - Added a test case to verify that the scope ID is preserved when converting the IP address in the ``IPv6Interface`` class. | ||
|
|
||
| Tests and Documentation: | ||
| - Updated the tests in ``Lib/test/test_ipaddress.py`` to include the new test case. | ||
| - No changes to documentation as the behavior is expected and intuitive. | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.