Skip to content

Added filtering logic based on the included/excluded items in ns #129571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Added filtering logic based on the included/excluded items in ns #129571

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion PC/layout/support/props.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,6 @@

def get_props_layout(ns):
if ns.include_all or ns.include_props:
# TODO: Filter contents of props file according to included/excluded items
d = dict(PROPS_DATA)
if not d.get("PYTHON_PLATFORM"):
d["PYTHON_PLATFORM"] = {
Expand All @@ -91,5 +90,13 @@ def get_props_layout(ns):
"arm32": "ARM",
"arm64": "ARM64",
}[ns.arch]
# Filtering logic based on the included/excluded items in ns
if not ns.include_all:
if not ns.include_exe:
d["PYTHON_TARGET"] = d["PYTHON_TARGET"].replace('python*.exe', '')
if not ns.include_dll:
d["PYTHON_TARGET"] = d["PYTHON_TARGET"].replace('python*.dll', '')
if not ns.include_libs:
d["PYTHON_TARGET"] = ""
props = PROPS_TEMPLATE.format_map(d)
yield "python.props", ("python.props", props.encode("utf-8"))
Loading