-
-
Notifications
You must be signed in to change notification settings - Fork 33.2k
gh-129605: Fix crashing pyrepl when NameError occurres in __getattr__ method #129615
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
srinivasreddy
wants to merge
19
commits into
python:main
Choose a base branch
from
srinivasreddy:gh-129605
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 11 commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
2028bd8
Fix crashing pyrepl when NameError occurres in __getattr__ method
srinivasreddy ed4fb80
Fix test failures
srinivasreddy c416766
Update the test name
srinivasreddy d5b2a2f
Fix test failure
srinivasreddy 63da1db
Make the check simple
srinivasreddy e07c745
📜🤖 Added by blurb_it.
blurb-it[bot] 29090d2
Update NEWS.d description
srinivasreddy 418b1b9
Update patch
srinivasreddy 720d6e5
Merge branch 'main' into gh-129605
srinivasreddy bab4f8b
Merge branch 'main' into gh-129605
srinivasreddy dfa7a09
Fix Lint failure:
srinivasreddy c969cca
Address review comments
srinivasreddy 05a9858
Handle __getattribute__ case as well
srinivasreddy 12fd25e
Merge branch 'main' into gh-129605
srinivasreddy 2f25445
Merge branch 'main' into gh-129605
srinivasreddy af9d076
Update 2025-02-03-16-39-35.gh-issue-129605.sN_0uq.rst
srinivasreddy 842dc93
Add another test for NameError for property function, and also wrap e…
srinivasreddy f1cb1e3
Update the description
srinivasreddy 2f46caf
Address review comments
srinivasreddy File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 change: 1 addition & 0 deletions
1
Misc/NEWS.d/next/Library/2025-02-03-16-39-35.gh-issue-129605.sN_0uq.rst
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| Fix pyrepl crash when a :exc:`NameError` occurs in the ``__getattr__`` method. | ||
skirpichev marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This also happens with
__getattribute__.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Addressed 05a9858