GH-128682: Mark two more macros as escaping. #129645
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y_CLEAR as escaping
iritkatriel
approved these changes
Feb 4, 2025
srinivasreddy
pushed a commit
to srinivasreddy/cpython
that referenced
this pull request
Feb 7, 2025
Expand out SETLOCAL so that code generator can see the decref. Mark Py_CLEAR as escaping
cmaloney
pushed a commit
to cmaloney/cpython
that referenced
this pull request
Feb 8, 2025
Expand out SETLOCAL so that code generator can see the decref. Mark Py_CLEAR as escaping
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is less error prone, and potentially more efficient, to expand out
SETLOCALrather than just not whitelisting it,Expanding it out means that the code generator can see the explicit operations on the references.