Skip to content

GH-129715: Remove _DYNAMIC_EXIT #129716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Feb 7, 2025
Merged

GH-129715: Remove _DYNAMIC_EXIT #129716

merged 7 commits into from
Feb 7, 2025

Conversation

brandtbucher
Copy link
Member

@brandtbucher brandtbucher commented Feb 6, 2025 •
edited by bedevere-app bot
Loading

Makes all of our slowest JIT benchmarks normal again, and 1% faster overall. See the issue for rationale.

@brandtbucher brandtbucher added performance Performance or resource usage interpreter-core (Objects, Python, Grammar, and Parser dirs) topic-JIT labels Feb 6, 2025
@brandtbucher brandtbucher self-assigned this Feb 6, 2025
@bedevere-app bedevere-app bot mentioned this pull request Feb 6, 2025
Open
markshannon
markshannon approved these changes Feb 7, 2025
View reviewed changes
Copy link
Member

@markshannon markshannon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to have stats for the dynamic exit case.
Other than that, looks good.

Fell free to merge once those stats are added.

markshannon
markshannon reviewed Feb 7, 2025
View reviewed changes
@brandtbucher brandtbucher merged commit 5fa7e1b into python:main Feb 7, 2025
62 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@markshannon markshannon markshannon approved these changes

@Fidget-Spinner Fidget-Spinner Awaiting requested review from Fidget-Spinner Fidget-Spinner is a code owner

Assignees

@brandtbucher brandtbucher

Labels

interpreter-core (Objects, Python, Grammar, and Parser dirs) performance Performance or resource usage topic-JIT

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@brandtbucher @markshannon