Skip to content

gh-129719: Restore missing socket.CAN_RAW_ERR_FILTER on Linux #129721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Apr 18, 2025
Merged

gh-129719: Restore missing socket.CAN_RAW_ERR_FILTER on Linux #129721

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
9dba4b7
gh-129719: Restore missing socket.CAN_RAW_ERR_FILTER on Linux
jbogers Feb 6, 2025
bde35e3
Put changes in correct section of documentation
jbogers Feb 6, 2025
886127c
📜🤖 Added by blurb_it.
blurb-it[bot] Feb 6, 2025
c07ac70
Put news in proper section
jbogers Feb 6, 2025
98e7c8c
Process review comments from @ZeroIntensity
jbogers Feb 6, 2025
02d4b84
Fix whitespace change
jbogers Feb 6, 2025
1739550
Fix documentation error.
jbogers Feb 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions Doc/library/socket.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -473,6 +473,9 @@ Constants
.. versionchanged:: 3.11
NetBSD support was added.

.. versionchanged:: next
Restored missing ``CAN_RAW_ERR_FILTER`` on Linux.

.. data:: CAN_BCM
CAN_BCM_*

Expand Down
1 change: 1 addition & 0 deletions Misc/NEWS.d/next/Library/2025-02-06-11-23-51.gh-issue-129719.Of6rvb.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fix missing :data:`socket.CAN_RAW_ERR_FILTER` constant in the socket module on Linux systems. It was missing since Python 3.11.
2 changes: 1 addition & 1 deletion Modules/socketmodule.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8223,7 +8223,7 @@ socket_exec(PyObject *m)
#endif
#if defined(HAVE_LINUX_CAN_RAW_H) || defined(HAVE_NETCAN_CAN_H)
ADD_INT_MACRO(m, CAN_RAW_FILTER);
#ifdef CAN_RAW_ERR_FILTER
#ifdef HAVE_LINUX_CAN_RAW_H
ADD_INT_MACRO(m, CAN_RAW_ERR_FILTER);
#endif
ADD_INT_MACRO(m, CAN_RAW_LOOPBACK);
Expand Down
Loading