Skip to content

refactor logging: Or assignment instead of if-else blocks #129722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

refactor logging: Or assignment instead of if-else blocks #129722

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 2 additions & 8 deletions Lib/logging/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -741,10 +741,7 @@ def __init__(self, linefmt=None):
Optionally specify a formatter which will be used to format each
individual record.
"""
if linefmt:
self.linefmt = linefmt
else:
self.linefmt = _defaultFormatter
self.linefmt = linefmt or _defaultFormatter

def formatHeader(self, records):
"""
Expand Down Expand Up @@ -991,10 +988,7 @@ def format(self, record):
If a formatter is set, use it. Otherwise, use the default formatter
for the module.
"""
if self.formatter:
fmt = self.formatter
else:
fmt = _defaultFormatter
fmt = self.formatter or _defaultFormatter
return fmt.format(record)

def emit(self, record):
Expand Down
Loading