gh-129805: Fix bytes annotation in Tools/jit
#129806
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sobolevn
requested review from
brandtbucher and
savannahostrowski
as code owners
AlexWaygood
approved these changes
Feb 16, 2025
|
Thanks @sobolevn for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13. |
|
Sorry, @sobolevn, I could not cleanly backport this to |
sobolevn
added a commit
to sobolevn/cpython
that referenced
this pull request
Feb 17, 2025
…GH-129806) (cherry picked from commit 422f8e9) Co-authored-by: sobolevn <[email protected]>
|
GH-130216 is a backport of this pull request to the 3.13 branch. |
brandtbucher
added a commit
to brandtbucher/cpython
that referenced
this pull request
May 6, 2025
brandtbucher
added a commit
that referenced
this pull request
Sep 16, 2025
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 16, 2025
…-133540) (cherry picked from commit 55e29a6) Co-authored-by: Brandt Bucher <[email protected]>
hugovk
pushed a commit
that referenced
this pull request
Oct 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I can confirm that this now passes
--strict-bytescheck from mypy:We can yet use
[email protected]in CPython to verify it, because there are known regressions :(Tools/jithas severalbytesandbytearraymixups #129805