-
-
Notifications
You must be signed in to change notification settings - Fork 33.2k
gh-95461: Add some parameters in CreateKeyEx and OpenKeyEx in winreg #129903
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, and I'd appreciate having the extra option there! Just need those audit events reverted - I don't think we need new ones.
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nearly there! Most important thing now I think is updating the real docs in Doc\library\winreg.rst.
| An integer that specifies an access mask that describes the desired | ||
| security access for the key. Default is KEY_READ. | ||
| options: int = 0 | ||
| Can be one of the REG_OPTION_* constants. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should probably document the interaction with reserved here. I'm not sure what the history is of reserved becoming a meaningful parameter, but it's meaningful now, so we should say that here (and in the real docs, Doc\library\winreg.rst). (I mean "here" as in a few lines above, but I can't comment on it because it hasn't been updated yet).
Co-authored-by: Steve Dower <[email protected]>
|
Hi, I just noticed that currently |
|
Hmm... perhaps we would be better to look at this as a stepping stone to replacing the
And keep |
Uh oh!
There was an error while loading. Please reload this page.