gh-129926: Speed up sqlite3.Row item access #129927
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc. @picnixz |
eendebakpt
reviewed
Feb 10, 2025
erlend-aasland
added
the
🔨 test-with-refleak-buildbots
This comment was marked as outdated.
This comment was marked as outdated.
bedevere-bot
removed
the
🔨 test-with-refleak-buildbots
|
The aarch64 fedora buildbot failure is unreleated. |
eendebakpt
approved these changes
Jun 20, 2025
| if (!PyUnicode_Check(left) || !PyUnicode_Check(right)) { | ||
| return 0; | ||
| } | ||
| assert(PyUnicode_Check(left)); |
There was a problem hiding this comment.
If left and right are always unicode, could we replace the PyObject_RichCompareBool with a unicode comparison such as PyUnicode_Compare for performance?
There was a problem hiding this comment.
They can be subclasses, in which case PyUnicode_Compare won't trigger on custom __eq__ IIRC.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.