Skip to content

Conversation

@WolframAlph
Copy link
Contributor

@WolframAlph WolframAlph commented Feb 10, 2025

Codegen expects unary & binary complex constant expressions already folded. Without it, we cannot proceed with migration of unaryop & binaryop to CFG. cc @Eclips4 @tomasr8

This PR does 2 things:

  1. Implement unary & binary complex constant expression folding in codegen to prepare for binary & unary folding migration.
  2. Make AST optimization optional, to test mentioned changes.

This PR is created in case we decide to go with this approach.

@WolframAlph WolframAlph marked this pull request as draft February 10, 2025 16:43
@WolframAlph WolframAlph changed the title gh-126835: Fold unary & binary complex constant expressions in codegen gh-126835: Fold unary & binary complex constant expressions during code generation. Feb 10, 2025
@WolframAlph
Copy link
Contributor Author

Used different approach in the end.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant