gh-129912: Fix documentation to correct references to Py_TPFLAGS_MANAGED_DICT in… #130044
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All commit authors signed the Contributor License Agreement. |
bedevere-app
bot
added
docs
colesbury
reviewed
Feb 12, 2025
colesbury
approved these changes
Feb 12, 2025
|
Thanks! |
colesbury
added
needs backport to 3.12
|
Thanks @isatyamks for the PR, and @colesbury for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Feb 12, 2025
…h-130044) (cherry picked from commit 791cdfe) Co-authored-by: Satyam Kumar <[email protected]>
|
GH-130059 is a backport of this pull request to the 3.13 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Feb 12, 2025
…h-130044) (cherry picked from commit 791cdfe) Co-authored-by: Satyam Kumar <[email protected]>
|
GH-130060 is a backport of this pull request to the 3.12 branch. |
colesbury
pushed a commit
that referenced
this pull request
Feb 12, 2025
) (gh-130060) (cherry picked from commit 791cdfe) Co-authored-by: Satyam Kumar <[email protected]>
colesbury
pushed a commit
that referenced
this pull request
Feb 12, 2025
) (gh-130059) (cherry picked from commit 791cdfe) Co-authored-by: Satyam Kumar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gh-129912: The documentation incorrectly states that setting both Py_TPFLAGS_MANAGED_WEAKREF and tp_dictoffset is an error. However, the correct flag should be Py_TPFLAGS_MANAGED_DICT instead of Py_TPFLAGS_MANAGED_WEAKREF.
This is a minor documentation fix and does not impact runtime behavior.
📚 Documentation preview 📚: https://cpython-previews--130044.org.readthedocs.build/