Skip to content

gh-130080: return in finally in subprocess.py #130081

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 16, 2025
Merged

gh-130080: return in finally in subprocess.py #130081

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions Lib/subprocess.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1123,10 +1123,9 @@ def __exit__(self, exc_type, value, traceback):
except TimeoutExpired:
pass
self._sigint_wait_secs = 0 # Note that this has been done.
return # resume the KeyboardInterrupt

# Wait for the process to terminate, to avoid zombies.
self.wait()
else:
# Wait for the process to terminate, to avoid zombies.
self.wait()

def __del__(self, _maxsize=sys.maxsize, _warn=warnings.warn):
if not self._child_created:
Expand Down
Loading