Skip to content

gh-130141: clean up asyncio._SelectorTransport during __del__ #130142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

gh-130141: clean up asyncio._SelectorTransport during __del__ #130142

wants to merge 1 commit into from
+29 −4

Conversation

@lunixbochs
Copy link
Contributor

@lunixbochs lunixbochs commented Feb 15, 2025 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request Feb 15, 2025
Open
@lunixbochs
pythongh-130141: clean up asyncio._SelectorTransport during __del__
b5f4ce6 
aligns the SelectorTransport __del__ implementation with force_close
also sets sock_fd to -1 when closing the socket so stale fds can't be
reused
@lunixbochs lunixbochs changed the title gh-130141: mark _SelectorTransport as closing during del gh-130141: clean up asyncio._SelectorTransport during __del__ Feb 19, 2025
kumaraditya303
kumaraditya303 reviewed Apr 20, 2025
View reviewed changes
@gvanrossum gvanrossum changed the title gh-130141: clean up asyncio._SelectorTransport during __del__ gh-130141: clean up asyncio._SelectorTransport during __del__ Jun 12, 2025
gvanrossum
gvanrossum reviewed Jun 12, 2025
View reviewed changes
Copy link
Member

@gvanrossum gvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM, but I would still like to see a test that proves it works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gvanrossum gvanrossum gvanrossum left review comments

@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner

@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner

@willingc willingc Awaiting requested review from willingc willingc is a code owner

@kumaraditya303 kumaraditya303 Awaiting requested review from kumaraditya303 kumaraditya303 is a code owner

Assignees

No one assigned

Labels

awaiting review topic-asyncio

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@lunixbochs @gvanrossum @kumaraditya303 @ZeroIntensity