Skip to content

gh-130151: Fix reference leaks in _hashlib.hmac_{new,digest} #130152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Feb 24, 2025
Merged

gh-130151: Fix reference leaks in _hashlib.hmac_{new,digest} #130152

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
1ac957b
fix leak in `_hashlib.hmac_new`
picnixz Feb 15, 2025
c41e3d0
fix leak in `hmac_digest`
picnixz Feb 15, 2025
972479d
fix exception type in `_hashlib.HMAC.copy`
picnixz Feb 15, 2025
c9d0c0d
blurb
picnixz Feb 15, 2025
c72c07e
revert to ANSI C style
picnixz Feb 22, 2025
7946bd8
reduce diff
picnixz Feb 22, 2025
1dcb55e
Merge branch 'main' into fix/hmac/leak-130151
picnixz Feb 22, 2025
480e14f
keep the typecast on PyObject_New
gpshead Feb 23, 2025
2a571de
undo that typecase, not necessary due to the macro
gpshead Feb 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Modules/_hashopenssl.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1684,7 +1684,7 @@ _hashlib_HMAC_copy_impl(HMACobject *self)
return _setException(PyExc_ValueError, NULL);
}

retval = PyObject_New(HMACobject, Py_TYPE(self));
retval = (HMACobject *)PyObject_New(HMACobject, Py_TYPE(self));
if (retval == NULL) {
HMAC_CTX_free(ctx);
return NULL;
Expand Down
Loading