Skip to content

gh-130167: Improve speed of difflib.IS_LINE_JUNK by replacing re #130170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
May 1, 2025
Merged

gh-130167: Improve speed of difflib.IS_LINE_JUNK by replacing re #130170

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
8f2670d
Improve speed of difflib.IS_LINE_JUNK by replacing re
donBarbos Feb 16, 2025
0fae9c5
Update difflib.py
donBarbos Feb 16, 2025
352b4bc
Update difflib.py
donBarbos Feb 16, 2025
0ab8da8
Add backward compatibility
donBarbos Feb 16, 2025
64dff4a
Update difflib.py
donBarbos Feb 16, 2025
32337c3
Update Lib/difflib.py
donBarbos Feb 16, 2025
390b6e7
Update difflib.py
donBarbos Feb 17, 2025
30d4535
Back `iff` word
donBarbos Feb 18, 2025
0e7293d
Update difflib
donBarbos Feb 18, 2025
bcf45a3
Update difflib.py
donBarbos Feb 18, 2025
46a4126
Fix News message
donBarbos Apr 27, 2025
60951fb
Improve clarity of expression
AA-Turner May 1, 2025
9d987b4
Revert, but add explanatory comments
AA-Turner May 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions Lib/difflib.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1053,8 +1053,7 @@ def IS_LINE_JUNK(line, pat=None):
"""

if pat is None:
stripped = line.strip()
return stripped == '' or stripped == '#'
return line.strip() in ('', '#')
return pat(line) is not None

def IS_CHARACTER_JUNK(ch, ws=" \t"):
Expand Down
Loading