pathlib ABCs: remove caching of path parser case sensitivity #130194
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the caching `_is_case_sensitive()` function. This makes the `pathlib._abc` module a little easier to backport to Python 3.8, where `functools.cache()` is unavailable. This has no effect on `pathlib.PurePath` nor `Path`; these classes use `self.parser is posixpath` to detect case sensitivity.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the caching
_is_case_sensitive()function.The cache used to speed up
PurePath.[full_]match()andPath.[r]glob(), but that's no longer the case - these methods useself.parser is posixpathto determine case sensitivity.This makes the
pathlib._abcmodule a little easier to backport to Python 3.8, wherefunctools.cache()is unavailable.