Skip to content

gh-130261: Append subprocess stderr in CalledProcessError.__str__() #130262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

gh-130261: Append subprocess stderr in CalledProcessError.__str__() #130262

wants to merge 1 commit into from

Conversation

@georgthegreat
Copy link
Contributor

@georgthegreat georgthegreat commented Feb 18, 2025 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request Feb 18, 2025
Closed
StanFromIreland
StanFromIreland requested changes Feb 18, 2025
View reviewed changes
Copy link
Member

@StanFromIreland StanFromIreland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have to either keep the "." or update the tests.

@georgthegreat
Copy link
Contributor Author

This is definitely not the final variant.

It is intentionally dirty to demonstrate the idea without beautifying the code.
It will be polished if maintainers are OK with the change.

@georgthegreat georgthegreat deleted the subprocess-stderr branch February 19, 2025 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@StanFromIreland StanFromIreland StanFromIreland requested changes

@gpshead gpshead Awaiting requested review from gpshead gpshead is a code owner

Assignees

No one assigned

Labels

awaiting core review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@georgthegreat @StanFromIreland