-
-
Notifications
You must be signed in to change notification settings - Fork 33.2k
gh-107773: Make datetime subclass repr consistent both implementations
#130308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Might be nice to add the reproducer from #107773 as a test, if only to make sure this does not regress and that the C and Python implementations remain in sync. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this approach. Thank you for developing it!
Just a couple of minor comments about the test implementation and I think this is good to go.
Co-authored-by: Jason R. Coombs <[email protected]>
|
@jaraco thank you for the comments, I added your suggestions 👍 |
|
Sorry, I was in a hurry to ping you, but now everything seems to be ready |
|
|
The buildbot failures appear unrelated to this change, so I'm going to assume they're not related, but if someone finds otherwise, please don't hesitate to ping me or back out the change and we can revisit.\ |
…ementations (python#130308) --------- Co-authored-by: Jason R. Coombs <[email protected]>
New behavior:
Old behavior: