Skip to content

gh-130320: gettext: Test fallback translations #130321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Apr 10, 2025
Merged

gh-130320: gettext: Test fallback translations #130321

Changes from 2 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
6a456f0
Test fallback translations
tomasr8 Feb 19, 2025
339ada5
Remove extra space
tomasr8 Feb 19, 2025
265646e
Test each gettext function separately
tomasr8 Feb 20, 2025
4e923f2
Better distinguish nested fallbacks
tomasr8 Feb 20, 2025
0b8fb70
Make linter happy
tomasr8 Feb 20, 2025
1c4935c
Test the order of overloads
tomasr8 Feb 23, 2025
80f2491
Remove NestedFallback2
tomasr8 Feb 23, 2025
45b152f
Avoid testing private attributes
tomasr8 Feb 23, 2025
92ac640
Merge remote-tracking branch 'upstream/main' into gettext-fallback
tomasr8 Apr 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 33 additions & 0 deletions Lib/test/test_gettext.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -691,6 +691,39 @@ def test_cache(self):
self.assertEqual(t.__class__, DummyGNUTranslations)


class FallbackTranslations(gettext.NullTranslations):
def gettext(self, *args):
return 'gettext'

ngettext = pgettext = npgettext = gettext


class FallbackTestCase(GettextBaseTest):
def test_null_translations_fallback(self):
t = gettext.NullTranslations()
t.add_fallback(FallbackTranslations())
self.assertEqual(t.gettext('foo'), 'gettext')
self.assertEqual(t.ngettext('foo', 'foos', 1), 'gettext')
self.assertEqual(t.pgettext('context', 'foo'), 'gettext')
self.assertEqual(t.npgettext('context', 'foo', 'foos', 1), 'gettext')

def test_gnu_translations_fallback(self):
with open(MOFILE, 'rb') as fp:
t = gettext.GNUTranslations(fp)
t.add_fallback(FallbackTranslations())
self.assertEqual(t.gettext('foo'), 'gettext')
self.assertEqual(t.ngettext('foo', 'foos', 1), 'gettext')
self.assertEqual(t.pgettext('context', 'foo'), 'gettext')
self.assertEqual(t.npgettext('context', 'foo', 'foos', 1), 'gettext')

def test_nested_fallbacks(self):
t = gettext.NullTranslations()
t.add_fallback(gettext.NullTranslations())
t.add_fallback(gettext.NullTranslations())
t.add_fallback(FallbackTranslations())
self.assertEqual(t.gettext('foo'), 'gettext')


class MiscTestCase(unittest.TestCase):
def test__all__(self):
support.check__all__(self, gettext,
Expand Down
Loading