-
-
Notifications
You must be signed in to change notification settings - Fork 33.2k
gh-77065: Add optional keyword-only argument echo_char for getpass.getpass
#130496
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 6 commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
d2b3f74
Add optional argument `mask` for `getpass.getpass`
donBarbos 8d9d83d
Merge branch 'main' into issue-77065
donBarbos 413a9ff
Update Lib/getpass.py
donBarbos 9ac2ae2
Revert passwd empty string
donBarbos 0ae2b81
Rename argument
donBarbos da00d07
rename argument in news entry
donBarbos 6c71075
accept suggestions
donBarbos 946d718
Rename _input_with_echochar function
donBarbos e2351ab
add suggestions
donBarbos 75e37bc
Add echochar check for ASCII
donBarbos cd08e68
echochar must be ascii
donBarbos bcdf95a
fix check rule
donBarbos 501d704
Update checks rules
donBarbos b6b822f
remove len check
donBarbos affd84a
Merge branch 'main' into issue-77065
donBarbos 977389a
Update 3.14.rst
donBarbos 59da53c
Add test
donBarbos 3c027d4
Add handle of new cases
donBarbos 81e71a9
Add test case with control chars
donBarbos ba236ee
Back old name of test function
donBarbos c608b7a
Update
donBarbos 17a5891
Add update tests
donBarbos 08e8686
Accept suggestions
donBarbos 4319f23
Rename
donBarbos File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 2 additions & 0 deletions
2
Misc/NEWS.d/next/Library/2025-02-24-07-08-11.gh-issue-77065.8uW0Wf.rst
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| Add keyword-only optional argument *echochar* for :meth:`getpass.getpass`. | ||
| Patch by Semyon Moroz. | ||
donBarbos marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.