Skip to content

Conversation

@Xiaokang2022
Copy link
Contributor

@Xiaokang2022 Xiaokang2022 commented Feb 24, 2025

@Xiaokang2022
Copy link
Contributor Author

@serhiy-storchaka Sorry to bother you, can you please help review this PR? Thank you so much!

@serhiy-storchaka serhiy-storchaka self-requested a review May 1, 2025 14:24
Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 👍

I left few suggestions for tests. You can accept them or reject.

@Xiaokang2022
Copy link
Contributor Author

LGTM. 👍

I left few suggestions for tests. You can accept them or reject.

Thank you for helping to review this PR. I have accepted all of your suggestions.

@serhiy-storchaka serhiy-storchaka merged commit e490c00 into python:main May 2, 2025
39 checks passed
@serhiy-storchaka
Copy link
Member

Thank you for your contribution @Xiaokang2022.

@Xiaokang2022 Xiaokang2022 deleted the improve-OptionMenu branch May 2, 2025 11:41
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants